DRAFT: Feat: Allow disabling SSL in OpenSearchCluster CRD with DisableSSL #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covert8
requested review from
idanl21,
jochenkressin,
pchmielnik,
prudhvigodithi,
salyh and
swoehrl-mw
as code owners
| func (r *TLSReconciler) Reconcile() (ctrl.Result, error) { | ||
| if r.instance.Spec.General.DisableSSL { | ||
| r.logger.Info("SSL is disabled. Skipping TLS setup") | ||
| r.reconcilerContext.AddConfig("plugins.security.disabled", "true") |
There was a problem hiding this comment.
This disables the security plugin and it is much more than disabling SSL.
If the original issue only requires to disable REST layer TLS(which users interact mainly), then we need to set plugins.security.ssl.http.enabled as false. Its default value is false and operator sets it as true here.
There is no option to disable TLS for transport layer yet. opensearch-project/security#4759
Fix: opensearch-project#967 bassed on pr: opensearch-project#966 Signed-off-by: Louis Roebben <[email protected]>
covert8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to disable SSL/TLS in the OpenSearch cluster by introducing a new configuration option DisableSSL in the OpenSearchCluster CRD. When enabled, this option configures the cluster to operate without SSL encryption, which can be useful for development environments or in secure, isolated networks.
based on pr: #966
Issues Resolved
Fix: #967
Check List
make lint)linter shows errors, but they appear to be pre-existing
infrastructure issues unrelated to the DisableSSL changes
If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.