feat: add NFS volume support to OpenSearchCluster CRD #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add native NFS volume support to additionalVolumes configuration,
enabling direct mounting of NFS shares for snapshot repositories
and other use cases without external workarounds.
Changes:
- Add NFS field to AdditionalVolume struct in CRD schema
- Implement NFS volume mounting logic in CreateAdditionalVolumes
function
- Update CRD manifests with NFS volume validation (server and path
required)
- Add comprehensive example configuration showing NFS integration with
snapshot repositories
- Update Helm chart CRD files
This allows operators to configure NFS-based snapshot repositories
directly in the OpenSearchCluster spec:
```yaml
spec:
general:
additionalVolumes:
- name: nfs-backups
path: /mnt/backups/opensearch
nfs:
server: 192.168.1.233
path: /export/backups/opensearch
```
Fixes
opensearch-project#1088
Signed-off-by: Itamar Syn-Hershko <[email protected]>
synhershko
requested review from
idanl21,
jochenkressin,
pchmielnik,
prudhvigodithi,
salyh and
swoehrl-mw
as code owners
|
Notes for myself
|
Signed-off-by: josedev-union <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add native NFS volume support to additionalVolumes configuration, enabling direct mounting of NFS shares for snapshot repositories and other use cases without external workarounds.
Changes:
This allows operators to configure NFS-based snapshot repositories directly in the OpenSearchCluster spec:
Fixes
#1088
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.