Fix #1079: Set setVMMaxMapCount default to true for production readiness #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… production readiness OpenSearch requires vm.max_map_count >= 262144 to prevent bootstrap failures in production deployments. The previous default of false would cause OpenSearch to fail on most Kubernetes nodes that have the default vm.max_map_count value of 65530. Changes: - Add kubebuilder:default=true annotation to SetVMMaxMapCount field - Regenerate CRD manifests with the new default value - Update documentation to clarify the default behavior This ensures production-ready deployments work out of the box while maintaining security by requiring explicit configuration. Signed-off-by: Itamar Syn-Hershko <[email protected]>
synhershko
requested review from
idanl21,
jochenkressin,
pchmielnik,
prudhvigodithi,
salyh and
swoehrl-mw
as code owners
|
Thank you for the fix. But does crd.md file should be corrected here too ? opensearch-k8s-operator/docs/designs/crd.md Line 170 in d6dce30 |
Good catch |
Signed-off-by: josedev-union <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSearch requires vm.max_map_count >= 262144 to prevent bootstrap failures
in production deployments. The previous default of false would cause OpenSearch to fail on most Kubernetes nodes that have the default vm.max_map_count value of 65530.
Changes:
This ensures production-ready deployments work out of the box while maintaining security by requiring explicit configuration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.