Skip to content

Conversation

@amitgalitz
Copy link
Member

Description

Adding create and start to AD node client.

Involves creating new constructor for a few request types were we pass AD cluster settings from rest layer and utilizing cluster setting fetching in transport layer instead for plugin to plugin communication.

Check List

  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 86.23188% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.39%. Comparing base (a6c1916) to head (abd0c6f).

Files with missing lines Patch % Lines
...transport/IndexAnomalyDetectorTransportAction.java 74.07% 3 Missing and 4 partials ⚠️
...arch/ad/transport/IndexAnomalyDetectorRequest.java 77.27% 5 Missing ⚠️
...rch/ad/transport/IndexAnomalyDetectorResponse.java 77.77% 2 Missing ⚠️
...rg/opensearch/timeseries/transport/JobRequest.java 81.81% 2 Missing ⚠️
...g/opensearch/timeseries/transport/JobResponse.java 77.77% 2 Missing ⚠️
...s/transport/BaseValidateConfigTransportAction.java 95.83% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1611      +/-   ##
============================================
+ Coverage     81.31%   81.39%   +0.07%     
- Complexity     6144     6174      +30     
============================================
  Files           542      542              
  Lines         24998    25105     +107     
  Branches       2543     2551       +8     
============================================
+ Hits          20328    20435     +107     
- Misses         3394     3396       +2     
+ Partials       1276     1274       -2     
Flag Coverage Δ
plugin 81.39% <86.23%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/opensearch/ad/client/AnomalyDetectionClient.java 100.00% <100.00%> (ø)
...ensearch/ad/client/AnomalyDetectionNodeClient.java 100.00% <100.00%> (ø)
...d/transport/AnomalyDetectorJobTransportAction.java 100.00% <ø> (ø)
...nsport/ValidateAnomalyDetectorTransportAction.java 100.00% <ø> (ø)
...recast/transport/ForecasterJobTransportAction.java 100.00% <ø> (ø)
...t/transport/ValidateForecasterTransportAction.java 100.00% <ø> (ø)
...h/timeseries/transport/BaseJobTransportAction.java 88.63% <100.00%> (+0.54%) ⬆️
...ch/timeseries/transport/ValidateConfigRequest.java 84.90% <100.00%> (+0.59%) ⬆️
...s/transport/BaseValidateConfigTransportAction.java 77.39% <95.83%> (+4.56%) ⬆️
...rch/ad/transport/IndexAnomalyDetectorResponse.java 95.12% <77.77%> (-4.88%) ⬇️
... and 4 more

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant