PPL Alerting: Models #1955
Open
PPL Alerting: Models #1955
+2,215
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toepkerd
force-pushed
the
ppl-review-1
branch
from
5c984dc to
6bd4c6f
Compare
toepkerd
changed the title
toepkerd
force-pushed
the
ppl-review-1
branch
from
6bd4c6f to
4e0f861
Compare
|
Please put the alerting data models in alerting subproject. Core is for the scheduled jobs models. Reference before we moved data models to common-utils: https://github.com/opensearch-project/alerting/tree/1.3/alerting/src/main/kotlin/org/opensearch/alerting |
|
Will move models to alerting subproject. The one thing that will stay in core (that isn't scheduled job related) is the PPL Plugin Transport Interface. This is needed in core to communicate with the PPL plugin, much like the existing code in core to communicate with the Notifications plugin. |
toepkerd
force-pushed
the
ppl-review-1
branch
3 times, most recently
from
46e45bd to
01a96ab
Compare
toepkerd
force-pushed
the
ppl-review-1
branch
from
01a96ab to
f047603
Compare
Signed-off-by: Dennis Toepker <[email protected]>
toepkerd
force-pushed
the
ppl-review-1
branch
from
f047603 to
d1041ec
Compare
toepkerd
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alerting core changes for PPL Alerting. This includes:
Related Issues
#1880
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.