Skip to content

Conversation

rishabhmaurya
Copy link
Contributor

Description

On disabling transport.ssl.enforce_hostname_verification, flight transport still uses goes through hostname verification. Ideally, it should honour this setting and skip verification.

Related Issues

Resolves #19578

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rishabhmaurya rishabhmaurya requested a review from a team as a code owner October 9, 2025 04:36
@rishabhmaurya rishabhmaurya self-assigned this Oct 9, 2025
@rishabhmaurya rishabhmaurya moved this from Todo to In Progress in Performance Roadmap Oct 9, 2025
@rishabhmaurya rishabhmaurya moved this from In Progress to In-Review in Performance Roadmap Oct 9, 2025
@rishabhmaurya rishabhmaurya requested a review from andrross October 9, 2025 04:38
@github-project-automation github-project-automation bot moved this from In-Review to In Progress in Performance Roadmap Oct 9, 2025
Copy link
Contributor

github-actions bot commented Oct 9, 2025

❌ Gradle check result for cbf05b9: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2025

✅ Gradle check result for cbf05b9: SUCCESS

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.99%. Comparing base (7a6b911) to head (cbf05b9).
⚠️ Report is 3 commits behind head on 3.3.

Files with missing lines Patch % Lines
...light/bootstrap/tls/DefaultSslContextProvider.java 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #19580      +/-   ##
============================================
- Coverage     72.99%   72.99%   -0.01%     
- Complexity    70483    70521      +38     
============================================
  Files          5717     5717              
  Lines        323051   323055       +4     
  Branches      46793    46794       +1     
============================================
- Hits         235826   235823       -3     
+ Misses        68259    68234      -25     
- Partials      18966    18998      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jainankitk jainankitk merged commit aea9cd2 into opensearch-project:3.3 Oct 9, 2025
39 of 44 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Oct 9, 2025
@rishabhmaurya rishabhmaurya deleted the enforce_hostname_verification branch October 9, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants