Combining filter rewrite and skip list to optimize sub aggregation #19573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing sub aggregation Signed-off-by: Ankit Jain <[email protected]>
jainankitk
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
a team
as code owners
Signed-off-by: Ankit Jain <[email protected]>
jainankitk
changed the title
Signed-off-by: Ankit Jain <[email protected]>
|
❌ Gradle check result for 82bc95d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ankit Jain <[email protected]>
|
❌ Gradle check result for aff3dc6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ankit Jain <[email protected]>
|
❌ Gradle check result for 1c29540: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ankit Jain <[email protected]>
|
{"run-benchmark-test": "id_8"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/4657/ . Final results will be published once the job is completed. |
|
The benchmark job https://build.ci.opensearch.org/job/benchmark-pull-request/4657/ failed. |
|
❌ Gradle check result for b9e9f2b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Seems to be due to the below error: @rishabh6788 - Can you help resolve this issue? |
Signed-off-by: Ankit Jain <[email protected]>
|
❕ Gradle check result for a28b9c1: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19573 +/- ##
============================================
+ Coverage 73.06% 73.10% +0.03%
- Complexity 70617 70633 +16
============================================
Files 5723 5725 +2
Lines 323473 323511 +38
Branches 46845 46849 +4
============================================
+ Hits 236348 236489 +141
+ Misses 68074 67908 -166
- Partials 19051 19114 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
{"run-benchmark-test": "id_8"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/4658/ . Final results will be published once the job is completed. |
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/4658/
|
|
I think big5 snapshot for 3.4 should have skiplist enabled for @timestamp. I tried out this change on big5, 20% data, sorted by @timestamp (default is no sort). [ec2-user@ip-172-31-61-197 ~]$ opensearch-benchmark compare -b 75193634-a102-4dc0-bff7-8e77af36a358 -c bb6304f5-89de-4bcb-a4a9-df2d2d3e5a20 / __ ____ ___ ____ / / ____ / / / __ ) ____ / / ____ ___ ____ / / Comparing baseline with contender
|
|
So AutoDateHistogram is different than DateHistogram, will need to add skiplist logic there as well: 
range_auto_date_histo_baseline.html |
|
Fixed the issue with my setup, it wasn't hitting the skiplist path. Now with skiplist its 20-30% worst latency. Async profile attached.
range_auto_date_histo_baseline.html |
Candidate - slowerOne big difference is I see is how much time is spent in Baseline
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change aims at optimizing the sub aggregation by leveraging multi range traversal for top level aggregation, and skip list for the sub aggregation.
I have copied over the
BitSetDocIdStreamclass in OpenSearch from Lucene for now as it is not public, but should look at eventually getting rid of it.Related Issues
Related to #17447, #19384
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.