Adding parquet-data-format, dataformat-csv, engine-datafusion for e2e… #19537
+3,768
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parquet ingestion/search
|
❌ Gradle check result for 2aa6905: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Bukhtawar
reviewed
Oct 8, 2025
Comment on lines
80
to
81
| /modules/parquet-data-format/src/main/rust/target | ||
| /modules/parquet-data-format/src/main/resources/native/ |
There was a problem hiding this comment.
Can we name this as codec-parquet/data-format-parquet
Bukhtawar
reviewed
Oct 8, 2025
Comment on lines
+9
to
+16
| apply plugin: 'opensearch.opensearchplugin' | ||
|
|
||
| opensearchplugin { | ||
| name = 'dataformat-csv' | ||
| description = 'CSV data format plugin for OpenSearch DataFusion' | ||
| classname = 'org.opensearch.datafusion.csv.CsvDataFormatPlugin' | ||
| hasNativeController = false | ||
| } |
There was a problem hiding this comment.
Assuming we can get rid of this?
Bukhtawar
reviewed
Oct 8, 2025
Comment on lines
+39
to
+49
|
|
||
| // TODO : move to vectorized exec specific plugin | ||
| @Override | ||
| public Optional<Map<org.opensearch.vectorized.execution.search.DataFormat, DataSourceCodec>> getDataSourceCodecs() { | ||
| Map<org.opensearch.vectorized.execution.search.DataFormat, DataSourceCodec> codecs = new HashMap<>(); | ||
| CsvDataSourceCodec csvDataSourceCodec = new CsvDataSourceCodec(); | ||
| // TODO : version it correctly - similar to lucene codecs? | ||
| codecs.put(csvDataSourceCodec.getDataFormat(), new CsvDataSourceCodec()); | ||
| return Optional.of(codecs); | ||
| // return Optional.empty(); | ||
| } |
There was a problem hiding this comment.
Based on the comment looks like this would be moved to core and common for all plugins that would register as a data source
Bukhtawar
reviewed
Oct 8, 2025
Comment on lines
+51
to
+60
| @Override | ||
| public <T extends DataFormat> IndexingExecutionEngine<T> indexingEngine(MapperService mapperService, ShardPath shardPath) { | ||
| if (CsvDataFormat.class.equals(getDataFormatType())) { | ||
| @SuppressWarnings("unchecked") | ||
| IndexingExecutionEngine<T> engine = (IndexingExecutionEngine<T>) new CsvEngine(); | ||
| return engine; | ||
| } | ||
| throw new IllegalArgumentException("Unsupported data format type: " + getDataFormatType()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I was wondering if this would require something like an EngineFactory to have support for remote directory with input as EngineConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… parquet ingestion/search
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.