-
Couldn't load subscription status.
- Fork 1.1k
[Explore] Add empty data validation to prevent visualization errors #10801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add data validation check before visualization processing - Only process visualizations when transformedData has content - Maintain error throwing for invalid visualization rules - Add comprehensive test coverage for empty data scenarios - Improve robustness of explore embeddable component Signed-off-by: Ansh Mohta <[email protected]> Signed-off-by: ansh mohta <[email protected]>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 10801.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 10801.yml under folder changelogs/fragments to complete this PR. File still missing. |
1 similar comment
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 10801.yml under folder changelogs/fragments to complete this PR. File still missing. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10801 +/- ##
==========================================
- Coverage 60.53% 60.52% -0.01%
==========================================
Files 4511 4511
Lines 121297 121298 +1
Branches 20237 20238 +1
==========================================
- Hits 73422 73421 -1
- Misses 42731 42733 +2
Partials 5144 5144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second approver since Owen approved
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration