Skip to content

Conversation

@AnshMohta-cloud
Copy link
Contributor

@AnshMohta-cloud AnshMohta-cloud commented Oct 24, 2025

  • Add data validation check before visualization processing
  • Only process visualizations when transformedData has content
  • Maintain error throwing for invalid visualization rules
  • Add comprehensive test coverage for empty data scenarios
  • Improve robustness of explore embeddable component

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: add empty data validation to prevent visualization errors

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

- Add data validation check before visualization processing
- Only process visualizations when transformedData has content
- Maintain error throwing for invalid visualization rules
- Add comprehensive test coverage for empty data scenarios
- Improve robustness of explore embeddable component

Signed-off-by: Ansh Mohta <[email protected]>
Signed-off-by: ansh mohta <[email protected]>
@github-actions
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 10801.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@github-actions
Copy link
Contributor

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 10801.yml under folder changelogs/fragments to complete this PR. File still missing.

1 similar comment
@github-actions
Copy link
Contributor

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 10801.yml under folder changelogs/fragments to complete this PR. File still missing.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.52%. Comparing base (0172967) to head (50a1c83).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...s/explore/public/embeddable/explore_embeddable.tsx 28.57% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10801      +/-   ##
==========================================
- Coverage   60.53%   60.52%   -0.01%     
==========================================
  Files        4511     4511              
  Lines      121297   121298       +1     
  Branches    20237    20238       +1     
==========================================
- Hits        73422    73421       -1     
- Misses      42731    42733       +2     
  Partials     5144     5144              
Flag Coverage Δ
Linux_1 26.56% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 39.07% <ø> (ø)
Linux_4 33.62% <28.57%> (+<0.01%) ⬆️
Windows_1 26.57% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 39.08% <ø> (+<0.01%) ⬆️
Windows_4 33.62% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approver since Owen approved

@ruanyl ruanyl merged commit 73d0065 into opensearch-project:main Oct 28, 2025
132 of 134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants