-
Couldn't load subscription status.
- Fork 1.1k
add navigate to page tool #10759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add navigate to page tool #10759
Conversation
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Signed-off-by: Jiaping Zeng <[email protected]>
13b02dd to
c5f6ccc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10759 +/- ##
=======================================
Coverage 60.51% 60.52%
=======================================
Files 4485 4486 +1
Lines 120190 120214 +24
Branches 19912 19922 +10
=======================================
+ Hits 72737 72758 +21
- Misses 42410 42413 +3
Partials 5043 5043
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| interface NavigateArgs { | ||
| appId: string; | ||
| path?: string; | ||
| description?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navigation has two other optional properties, replace and state. state is used to pass context/data and it might not be the correct way for context sharing for chatbot. It is often used to share some app states which I don't think this tool should manage. for replace, it can control whether navigation creates a new history entry (push) or replaces the current one (replace) which is useful if we need to navigate back and force. let's add replace?: boolean to follow the navigation pattern.
| if (!appId || typeof appId !== 'string') { | ||
| throw new Error('appId is required and must be a string'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also validate appId in services.application.applications$.getValue()? it might not be available or accessible. for example, explore is not accessible in analytic workspaces.
|
Nit: if we want to distinguish between appId not available or no permission, we could use |
Description
Add page navigation AG-UI tool.
Chat window and session is not currently preserved on navigation. Will address in future PR.
Issues Resolved
Screenshot
Tool can be detected by agent, then tried navigating to visualizations page which worked:

Temporarily disabled navigate to show that tool use renders correctly:

Testing the changes
Verified that backend agent can see the tool and that I can navigate to visualizations page from chat
Changelog
Check List
yarn test:jestyarn test:jest_integration