- 
                Notifications
    You must be signed in to change notification settings 
- Fork 468
Add dependency graph column to DependencyInsight recipes #6170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            bmuschko
  wants to merge
  24
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
bm/dependency-graph
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
            
          
                rewrite-gradle/src/main/java/org/openrewrite/gradle/search/DependencyInsight.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                rewrite-gradle/src/main/java/org/openrewrite/gradle/search/DependencyInsight.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What's changed?
Adds a new column to the Maven and Gradle DependencyInsight recipes that renders the full dependency graph for a dependency.
What's your motivation?
Allow end users to find out where a dependency comes from.
Anything in particular you'd like reviewers to focus on?
I made an additional change independent of rendering the dependency graph which is the deduplication of dependencies that appear in the graph multiple times (usually rendered by Gradle with the
*character to indicate a dependency duplicate).In regards to the change to the test
DependencyInsightTest.nestedDependenciesAreTransitivelySearchedForMatchingDependencies().Example:
The dependency
spring-boot-starter-logging:2.6.6is not "missing". It's being deduplicated because bothspring-boot-starter-webandspring-boot-starter-actuatordepend onspring-boot-starter:2.6.6, which containsspring-boot-starter-logging. The dependency only needs to be listed once in the markers, and it appears under the first dependency that brings it in (spring-boot-starter-web).