No empty UUID #720
Draft
No empty UUID #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wip: |
|
im stuck on this. How to proceed, please? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+18
to
+19
| import org.openrewrite.*; | ||
| import org.openrewrite.java.JavaIsoVisitor; |
There was a problem hiding this comment.
Suggested change
| import org.openrewrite.*; | |
| import org.openrewrite.java.JavaIsoVisitor; | |
| import org.jspecify.annotations.Nullable; | |
| import org.openrewrite.Cursor; | |
| import org.openrewrite.ExecutionContext; | |
| import org.openrewrite.Recipe; | |
| import org.openrewrite.TreeVisitor; | |
| import org.openrewrite.java.tree.Expression; | |
| import org.openrewrite.java.tree.J; |
| } | ||
|
|
||
| @Override | ||
| public J.If visitIf(J.If iff, ExecutionContext ctx) { |
There was a problem hiding this comment.
Suggested change
| public J.If visitIf(J.If iff, ExecutionContext ctx) { | |
| public J.@Nullable If visitIf(J.If iff, ExecutionContext ctx) { |
Comment on lines
+19
to
+20
| import org.openrewrite.DocumentExample; | ||
| import org.openrewrite.Issue; |
There was a problem hiding this comment.
Suggested change
| import org.openrewrite.DocumentExample; | |
| import org.openrewrite.Issue; | |
| import org.openrewrite.DocumentExample; |
| .parser(JavaParser.fromJavaVersion().classpath("junit-jupiter-params")); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Suggested change
| @Test | |
| @DocumentExample | |
| void uuidToStringIsBlankAlwaysFalse() { |
Comment on lines
+45
to
+47
| if (id.toString().isBlank()) { | ||
| System.out.println("This will never happen"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (id.toString().isBlank()) { | |
| System.out.println("This will never happen"); | |
| } | |
| boolean b = id.toString().isBlank(); // Always false |
| import java.util.UUID; | ||
| public class Test { | ||
| public void test() { | ||
| UUID id = UUID.randomUUID(); |
There was a problem hiding this comment.
Suggested change
| UUID id = UUID.randomUUID(); | |
| UUID id = UUID.randomUUID(); | |
| boolean b = false; // Always false |
Comment on lines
+63
to
+64
| @DocumentExample | ||
| @Test |
There was a problem hiding this comment.
Suggested change
| @DocumentExample | |
| @Test | |
| void uuidIsBlankInIfCondition() { |
| public class Test { | ||
| public void test() { | ||
| UUID id = UUID.randomUUID(); | ||
| boolean b = id.toString().isBlank(); // Always false |
There was a problem hiding this comment.
Suggested change
| boolean b = id.toString().isBlank(); // Always false | |
| if (id.toString().isBlank()) { | |
| System.out.println("This will never happen"); | |
| } |
Comment on lines
+82
to
+83
| UUID id = UUID.randomUUID(); | ||
| boolean b = false; // Always false |
There was a problem hiding this comment.
Suggested change
| UUID id = UUID.randomUUID(); | |
| boolean b = false; // Always false | |
| UUID id = UUID.randomUUID(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist