Verify support for multiple main source folders #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the support for additional test source folders added in PR #888, this change enables the rewrite-maven-plugin to process multiple main source directories configured via build-helper-maven-plugin or similar tools. Changes: - Modified MavenMojoProjectParser to iterate through all compile source roots using mavenProject.getCompileSourceRoots() instead of single source directory - Added integration test to verify recipes are applied to files in all main source directories - Follows the same pattern as the existing test source folder implementation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java
Outdated
Show resolved
Hide resolved
...unIT/multi_main_source_sets_project/src/additional-main/java/sample/AdditionalMainClass.java
Outdated
Show resolved
Hide resolved
...ewrite/maven/RewriteRunIT/multi_main_source_sets_project/src/main/java/sample/MainClass.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Likely fixed in |
timtebeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for multiple main source folders, mirroring the functionality added for test source folders in PR #888.
Motivation
Maven projects using
build-helper-maven-pluginor similar tools to configure additional source directories (e.g., for generated code, integration modules, or multi-source projects) need the rewrite-maven-plugin to process all configured main source directories, not just the defaultsrc/main/java.Changes
MavenMojoProjectParser.processMainSources()to iterate through all compile source roots usingmavenProject.getCompileSourceRoots()instead of only processing the single default source directorymulti_main_source_sets_projectto verify recipes are applied to files in all configured main source directoriesTesting
build-helper-maven-pluginSingleLineCommentsrecipe is applied to Java files in both:src/main/javasrc/additional-main/javaRelated
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]