Allowing check on different port #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bakins Sorry for the delay on my side. This is still in my review queue. I'll have a look as soon as I can manage. Thanks! |
|
Any chance of having this merged, we were about to write basically this exact patch! |
|
Any update on this @agentzh ? |
|
This PR is on conflicted now. Would you please rebase to the latest master? @NicoAdrian |
New PR is here: #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a few use cases where I need to actually test on a different port than the serving port.
My testing set up is currently broken, but this worked in my initial test install.