Adding variance of variance and normality tests for tally statistics

include/openmc/constants.h

@@ -281,7 +281,7 @@ enum class MgxsType {
 // ============================================================================
 // TALLY-RELATED CONSTANTS
 
-enum class TallyResult { VALUE, SUM, SUM_SQ, SIZE };
+enum class TallyResult { VALUE, SUM, SUM_SQ, SUM_THIRD, SUM_FOURTH, SIZE };
 
 enum class TallyType { VOLUME, MESH_SURFACE, SURFACE, PULSE_HEIGHT };
 

include/openmc/hdf5_interface.h

@@ -100,8 +100,8 @@ void read_llong(hid_t obj_id, const char* name, long long* buffer, bool indep);
 void read_string(
   hid_t obj_id, const char* name, size_t slen, char* buffer, bool indep);
 
-void read_tally_results(
-  hid_t group_id, hsize_t n_filter, hsize_t n_score, double* results);
+void read_tally_results(hid_t group_id, hsize_t n_filter, hsize_t n_score,
+  double* results, bool vov_results);
 void write_attr_double(hid_t obj_id, int ndim, const hsize_t* dims,
   const char* name, const double* buffer);
 void write_attr_int(hid_t obj_id, int ndim, const hsize_t* dims,
@@ -114,9 +114,9 @@ void write_int(hid_t group_id, int ndim, const hsize_t* dims, const char* name,
 void write_llong(hid_t group_id, int ndim, const hsize_t* dims,
   const char* name, const long long* buffer, bool indep);
 void write_string(hid_t group_id, int ndim, const hsize_t* dims, size_t slen,
-  const char* name, char const* buffer, bool indep);
-void write_tally_results(
-  hid_t group_id, hsize_t n_filter, hsize_t n_score, const double* results);
+  const char* name, const char* buffer, bool indep);
+void write_tally_results(hid_t group_id, hsize_t n_filter, hsize_t n_score,
+  const double* results, bool vov_results);
 } // extern "C"
 
 //==============================================================================

include/openmc/tallies/tally.h

@@ -106,6 +106,8 @@ class Tally {
 
   bool writable() const { return writable_; }
 
+  bool vov_results() const { return vov_; }
+
   //----------------------------------------------------------------------------
   // Other methods.
 
@@ -119,6 +121,8 @@ class Tally {
 
   void accumulate();
 
+  void accumulate_vov();
+
   //! return the index of a score specified by name
   int score_index(const std::string& score) const;
 
@@ -192,6 +196,8 @@ class Tally {
   //! Whether to multiply by atom density for reaction rates
   bool multiply_density_ {true};
 
+  bool vov_ = {false};
+
   int64_t index_;
 };
 

include/openmc/urr.h

@@ -27,10 +27,10 @@ class UrrData {
     double heating;
   };
 
-  Interpolation interp_;          //!< interpolation type
-  int inelastic_flag_;            //!< inelastic competition flag
-  int absorption_flag_;           //!< other absorption flag
-  bool multiply_smooth_;          //!< multiply by smooth cross section?
+  Interpolation interp_; //!< interpolation type
+  int inelastic_flag_;   //!< inelastic competition flag
+  int absorption_flag_;  //!< other absorption flag
+  bool multiply_smooth_; //!< multiply by smooth cross section?
 
   vector<double> energy_; //!< incident energies
   auto n_energy() const { return energy_.size(); }

include/openmc/volume_calc.h

@@ -1,3 +1,3 @@
 #ifndef OPENMC_VOLUME_CALC_H
 #define OPENMC_VOLUME_CALC_H
 
@@ -34,7 +34,7 @@
     vector<double> atoms;       //!< Number of atoms for each nuclide
     vector<double> uncertainty; //!< Uncertainty on number of atoms
     int iterations; //!< Number of iterations needed to obtain the results
-  };                // Results for a single domain
+  }; // Results for a single domain
 
   // Constructors
   VolumeCalculation(pugi::xml_node node);

openmc/__init__.py

@@ -24,6 +24,7 @@
 from openmc.trigger import *
 from openmc.tally_derivative import *
 from openmc.tallies import *
+from openmc.tally_stats import *
 from openmc.mgxs_library import *
 from openmc.executor import *
 from openmc.statepoint import *

openmc/settings.py

@@ -2078,7 +2078,7 @@ def _max_tracks_from_xml_element(self, root):
         text = get_text(root, 'max_tracks')
         if text is not None:
             self.max_tracks = int(text)
-
+            
     def _random_ray_from_xml_element(self, root):
         elem = root.find('random_ray')
         if elem is not None:

openmc/statepoint.py

@@ -429,6 +429,11 @@ def tallies(self):
                     if "multiply_density" in group.attrs:
                         tally.multiply_density = group.attrs["multiply_density"].item() > 0
 
+                    # Check if tally has vov attribute
+                    if "vov_results" in group.attrs:
+                        print("VOV results found", group.attrs["vov_results"].item())
+                        tally._vov = group.attrs["vov_results"].item()
+
                     # Read the number of realizations
                     n_realizations = group['n_realizations'][()]
 
@@ -460,6 +465,7 @@ def tallies(self):
                     # Add the scores to the Tally
                     scores = group['score_bins'][()]
                     tally.scores = [score.decode() for score in scores]
+                    print(scores.shape)
 
                     # Add Tally to the global dictionary of all Tallies
                     tally.sparse = self.sparse