Skip to content

Conversation

rm5248
Copy link
Contributor

@rm5248 rm5248 commented May 14, 2023

@rm5248
Copy link
Contributor Author

rm5248 commented May 14, 2023

New table for section 4.4 that makes more sense to me, explicitly showing that the data in byte 6 can change depending on the value of byte 1:
Screenshot from 2023-05-14 13-31-12

The other tables in the standard look fine to me, I don't think that they would have to change at all.

@bobjacobsen
Copy link
Contributor

bobjacobsen commented May 14, 2023 via email

@balazsracz
Copy link
Contributor

I disagree with this pull request. I specifically posted two concerns on the email thread referenced, and this pull request does not address either of those two concerns:

  • there are many tables (Bob pointed this out as well)
  • now there is duplication of information in the standard, which is a significantly worse presentation that carries forward risks.

I don't actually think the first concern can be addressed before addressing the second concern. So my question really is how do you propose to avoid the information duplication.

@rm5248
Copy link
Contributor Author

rm5248 commented May 15, 2023

I disagree with this pull request. I specifically posted two concerns on the email thread referenced, and this pull request does not address either of those two concerns:

* there are many tables (Bob pointed this out as well)

Yes, this is a draft to solicit feedback. The other tables can be updated as well, I haven't done that as I want to solicit feedback on this section first before making the same changes to other tables.

* now there is duplication of information in the standard, which is a significantly worse presentation that carries forward risks.

Please inform me as to what information you feel is duplicated and why that duplication is bad.

@atanisoft
Copy link

why that duplication is bad.

Duplication of information can be bad when it is spread across multiple documents as they will invariably get out of sync and become a maintenance issue. If the information is contained solely within a single document (S, TN, WN, etc) then it should be less of a concern.

@bobjacobsen bobjacobsen changed the title updating wording in Read Command section and fix incorrect section re… WIP: updating wording in Read Command section and fix incorrect section re… Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants