5705: Explain metaspace in rule results #654
Conversation
|
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
|
@Suchitainf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
| @@ -519,6 +520,8 @@ ManyRunningProcessesRule_TEXT_RECOMMENDATION=If this is a server environment, it | |||
| ManyRunningProcessesRule_INFO_LIMIT=Competing processes limit | |||
| ManyRunningProcessesRule_INFO_LIMIT_LONG=The number of simultaneous processes needed to trigger an info notice | |||
| MetaspaceOomRuleFactory_RULE_NAME=Metaspace Out of Memory | |||
| MetaspaceOomRuleFactory_TEXT_CAUSE=Java class metadata is allocated in native memory (metaspace). When the amount of native memory needed for a class metadata exceeds MaxMetaSpaceSize, a java.lang.OutOfMemoryError exception with a detail MetaSpace is thrown. The amount of metaspace that can be used for class metadata is limited by the parameter MaxMetaSpaceSize, which is specified on the command line. | |||
| MetaspaceOomRuleFactory_TEXT_ACTION=If MaxMetaSpaceSize, has been set on the command-line, increase its value. MetaSpace is allocated from the same address spaces as the Java heap. Reducing the size of the Java heap will make more space available for MetaSpace. | |||
There was a problem hiding this comment.
Not a blocker, but I think it'd be nice if we checked the flag events (if available). We can say both what the current value is, and if it was set on the command line adjust the text. Something like "MaxMetaspaceSize was set to {maxMetaspaceSize} on the command line, increasing this value may help resolve the error."
| @@ -519,6 +520,8 @@ ManyRunningProcessesRule_TEXT_RECOMMENDATION=If this is a server environment, it | |||
| ManyRunningProcessesRule_INFO_LIMIT=Competing processes limit | |||
| ManyRunningProcessesRule_INFO_LIMIT_LONG=The number of simultaneous processes needed to trigger an info notice | |||
| MetaspaceOomRuleFactory_RULE_NAME=Metaspace Out of Memory | |||
| MetaspaceOomRuleFactory_TEXT_CAUSE=Java class metadata is allocated in native memory (metaspace). When the amount of native memory needed for a class metadata exceeds MaxMetaSpaceSize, a java.lang.OutOfMemoryError exception with a detail MetaSpace is thrown. The amount of metaspace that can be used for class metadata is limited by the parameter MaxMetaSpaceSize, which is specified on the command line. | |||
There was a problem hiding this comment.
It should be MaxMetaspaceSize, not MaxMetaSpaceSize.
...ules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/MetaspaceOomRule.java
Outdated
Show resolved
Hide resolved
| @@ -519,10 +520,13 @@ ManyRunningProcessesRule_TEXT_RECOMMENDATION=If this is a server environment, it | |||
| ManyRunningProcessesRule_INFO_LIMIT=Competing processes limit | |||
| ManyRunningProcessesRule_INFO_LIMIT_LONG=The number of simultaneous processes needed to trigger an info notice | |||
| MetaspaceOomRuleFactory_RULE_NAME=Metaspace Out of Memory | |||
| MetaspaceOomRuleFactory_TEXT_CAUSE=Java class metadata is allocated in native memory (metaspace). When the amount of native memory needed for a class metadata exceeds MaxMetaspaceSize, a java.lang.OutOfMemoryError exception with a detail MetaSpace is thrown. The amount of metaspace that can be used for class metadata is limited by the parameter MaxMetaspaceSize, which is specified on the command line. | |||
There was a problem hiding this comment.
It should be Metaspace instead of MetaSpace here as well.
This enhancement updates MetaspaceOomRule and IncreasingMetaspaceLiveSetRule with the proper explanation and relevant real time values which were missing.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/654/head:pull/654$ git checkout pull/654Update a local copy of the PR:
$ git checkout pull/654$ git pull https://git.openjdk.org/jmc.git pull/654/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 654View PR using the GUI difftool:
$ git pr show -t 654Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/654.diff
Using Webrev
Link to Webrev Comment