Skip to content

8400: Add more show options for JMX Console graphs #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented May 31, 2025

Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8400: Add more show options for JMX Console graphs (New Feature - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/652/head:pull/652
$ git checkout pull/652

Update a local copy of the PR:
$ git checkout pull/652
$ git pull https://git.openjdk.org/jmc.git pull/652/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 652

View PR using the GUI difftool:
$ git pr show -t 652

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/652.diff

Using Webrev

Link to Webrev Comment

@thegreystone thegreystone requested a review from aptmac May 31, 2025 22:27
@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2025

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label May 31, 2025
@mlbridge
Copy link

mlbridge bot commented May 31, 2025

Webrevs

@thegreystone thegreystone requested a review from Gunde June 4, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant