8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError

[sercher]

Hi all,

These are parity backports with Oracle's 8u461, OpenJDK 8u462 is affected. The commit 46251bc6 didn't apply cleanly as JDK-8049870 hasn't been backported to jdk8u-dev. JDK-8290162 is basically a clean backport, the paths changed to 8u path scheme. The functional part of 5074006 applied cleanly in BasicOptionPaneUI.java. The test in TestJOptionHTMLTag.java was rewritten to get rid of dependency on PassFailJFrame (not in 8). Replaced the text block (JEP 355 style) with traditional string literals. The paths have been changed to the 8u path scheme. The test passes with the fix and fails otherwise.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8042134 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-5074006 needs maintainer approval
• JDK-8224267 needs maintainer approval
• JDK-8290162 needs maintainer approval

Issues

• JDK-8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError (Bug - P3)
• JDK-8290162: Reset recursion counter missed in fix of JDK-8224267 (Bug - P4)
• JDK-5074006: Swing JOptionPane shows </html> tag as a string after newline (Bug - P4)
• JDK-8042134: JOptionPane bungles HTML messages (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/659/head:pull/659
$ git checkout pull/659

Update a local copy of the PR:
$ git checkout pull/659
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/659/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 659

View PR using the GUI difftool:
$ git pr show -t 659

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/659.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (4b63d539)
• 00: Full (cc696566)

[sercher]

/issue add 8290162,5074006,8042134

[openjdk]

@sercher
Adding additional issue to issue list: 8290162: Reset recursion counter missed in fix of JDK-8224267.

Adding additional issue to issue list: 5074006: Swing JOptionPane shows </html> tag as a string after newline.

Adding additional issue to issue list: 8042134: JOptionPane bungles HTML messages.

[jerboaa]

@sercher Please get this reviewed, before applying for backport approval. Thanks!

[sercher]

Please get this reviewed, before applying for backport approval. Thanks!

Thanks @jerboaa, missed that.