-
Notifications
You must be signed in to change notification settings - Fork 162
8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ling Reviewed-by: dholmes
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/label add clean |
@sendaoYan |
Problemlist sun/security/tools/jarsigner/TimestampCheck.java in jdk8u before fixed PR openjdk/jdk8u-dev#642 been merged. Fixes: adoptium#6119 Signed-off-by: sendaoYan <[email protected]>
…#6120) Problemlist sun/security/tools/jarsigner/TimestampCheck.java in jdk8u before fixed PR openjdk/jdk8u-dev#642 been merged. Fixes: #6119 Signed-off-by: sendaoYan <[email protected]>
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, can anyone take look this PR. It's clean backport actually. This PR add more expierd time to avoid test failure, test-fix only, no risk. |
|
Thanks for the approve @phohensee /approval request Clean backport actually, add more expierd time to avoid test failure, test-fix only, no risk. |
@sendaoYan |
Thanks for the review and approved @phohensee @jerboaa /integrate |
@sendaoYan |
/sponsor |
Going to push as commit f08dd7f.
Your commit was automatically rebased without conflicts. |
@phohensee @sendaoYan Pushed as commit f08dd7f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks @phohensee |
Hi all,
This pull request contains a clean backport of commit 577ede73 from the openjdk/jdk repository.
The commit being backported was authored by Weijun Wang on 19 Mar 2025 and was reviewed by David Holmes.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/642/head:pull/642
$ git checkout pull/642
Update a local copy of the PR:
$ git checkout pull/642
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/642/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 642
View PR using the GUI difftool:
$ git pr show -t 642
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/642.diff
Using Webrev
Link to Webrev Comment