8294314: Minimize disabled warnings in hotspot

[mrserb]

Hi all,

This pull request contains a backport of commit 7743345f from the openjdk/jdk repository.

The commit being backported was authored by Magnus Ihse Bursie on 17 Oct 2022 and was reviewed by Erik Joelsson and Aleksey Shipilev.

The patch updates the code to handle certain warnings during compilation. It is part of the ongoing effort to migrate JDK 17 to the new toolchain, including Xcode 16, and will make further patches cleaner.

The patch is not clean because the next three are not in jdk17u:

• https://bugs.openjdk.org/browse/JDK-8286262 -> still need to disable 4996 warning
• https://bugs.openjdk.org/browse/JDK-8293182 -> still need to disable missing-field-initializers
• https://bugs.openjdk.org/browse/JDK-8303805 -> still need to disable strict-overflow

The next two are are already in jdk17u so context a little bit different:

• https://bugs.openjdk.org/browse/JDK-8300169
• https://bugs.openjdk.org/browse/JDK-8319818

Testing:

• github actions
• gcc: 7.3.1, 9.3.1, 10.5.0, 11.4.0, 11.5.0, 13.2.1 and 13.3.0
• xcode: 26, 26.0.1
• VS 2022

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8294314 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294314: Minimize disabled warnings in hotspot (Bug - P3 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4143/head:pull/4143
$ git checkout pull/4143

Update a local copy of the PR:
$ git checkout pull/4143
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4143

View PR using the GUI difftool:
$ git pr show -t 4143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4143.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294314: Minimize disabled warnings in hotspot

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• e3c50e1: 8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win)
• 9bf2571: 8328299: Convert DnDFileGroupDescriptor.html applet test to main

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 04: Full - Incremental (d4f4fb1d)
• 03: Full - Incremental (fd674045)
• 02: Full - Incremental (4157adaf)
• 01: Full - Incremental (9f8b0126)
• 00: Full (32855c22)

[mrserb]

I’m not sure what to do with files that don’t exist in jdk17u yet. For example(test_signals.cpp), if some tests were updated upstream(JDK-8292054) but haven’t been backported, should we exclude them from the current list for now, or add them once they’re backported? (we might forget to do that later.)

[mrserb]

found some issues on alpine on aarch64, working on that.

[mrserb]

found some issues on alpine on aarch64, working on that.

Not a regression of this patch, the master branch cannot be built as well due to missing JDK-8301493. I’ll address that in a separate backport.

hotspot/cpu/aarch64/interpreterRT_aarch64.cpp:270:33: error: operands to '?:' have different types 'std::nullptr_t' and 'intptr_t' {aka 'long int'}
  270 |     intptr_t value = *addr == 0 ? NULL : (intptr_t)addr;

[mrserb]

I’m not sure what to do with files that don’t exist in jdk17u yet. For example(test_signals.cpp), if some tests were updated upstream(JDK-8292054) but haven’t been backported, should we exclude them from the current list for now, or add them once they’re backported? (we might forget to do that later.)

I decided to drop it.

[mrserb]

@shipilev please take a look

[shipilev]

Looks fine to me, good job! I think we'll wait for another PR to land, upgrade to MacOS 15, and then see if this exclusion block is fine for all GHA platforms. How does that sound?

[shipilev]

Looks fine to me.

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mrserb]

/approval request
The patch updates the code to handle certain warnings during compilation. It was part of the ongoing effort to migrate JDK 17 to the new toolchain, including Xcode 16, and will make further patches cleaner.

[openjdk]

@mrserb
8294314: The approval request has been created successfully.