8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java

[toxaart]

Hi, please consider the following changes:

the mentioned test fails if run standalone with the following error:
Error: Not a test or directory containing tests: runtime/Monitor/MonitorWithDeadObjectTest.java

The order of jtreg tags is not correct, to make it pass standalone it is sufficient to put @test first in each test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26527/head:pull/26527
$ git checkout pull/26527

Update a local copy of the PR:
$ git checkout pull/26527
$ git pull https://git.openjdk.org/jdk.git pull/26527/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26527

View PR using the GUI difftool:
$ git pr show -t 26527

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26527.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back toxaart! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@toxaart This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java

Reviewed-by: stefank, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• ea75431: 8363928: Specifying AOTCacheOutput with a blank path causes the JVM to crash
• c239c0a: 8362564: hotspot/jtreg/compiler/c2/TestLWLockingCodeGen.java fails on static JDK on x86_64 with AVX instruction extensions
• 0226c02: 8364004: Expose VMError::controlledCrash via Whitebox
• ... and 16 more: https://git.openjdk.org/jdk/compare/011de4c894ed827ee8e15a7cfe400788175e5b2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@toxaart The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (25ac27c2)

[stefank]

I think the JBS issue summary needs to be updated to reflect that it is the @requires tag that is problematic and not the @bug tag.

I'm also wondering if there's anything we need to do to our test infrastructure to find these issues automatically? As I understand it, this was only found because @TobiHartmann went and manually tried to find issues like this. Maybe @lmesnik has some insights here or knows someone who deals with this part of the test infra.

[toxaart]

I think the JBS issue summary needs to be updated to reflect that it is the @requires tag that is problematic and not the @bug tag.

I updated the JBS issue as suggested.

[coleenp]

Looks good!