-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8364249: G1: Fix some comments about "maximum_collection" #26526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8364249: G1: Fix some comments about "maximum_collection" #26526
Conversation
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine and trivial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as is.
It might be better to add extra spaces at the below lines for alignment.
Going to push as commit 302508d.
Your commit was automatically rebased without conflicts. |
Hi all,
please review this trivial comment change to have them adhere to the formal parameter specification.
Testing: local compilation
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26526/head:pull/26526
$ git checkout pull/26526
Update a local copy of the PR:
$ git checkout pull/26526
$ git pull https://git.openjdk.org/jdk.git pull/26526/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26526
View PR using the GUI difftool:
$ git pr show -t 26526
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26526.diff
Using Webrev
Link to Webrev Comment