Skip to content

8363920: JVMTI Documentation for GetLocalDouble is wrong: refers to long #26521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Korov
Copy link
Contributor

@Korov Korov commented Jul 29, 2025

Hi all,

Fixed type errors in documentation, minor changes.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8363920: JVMTI Documentation for GetLocalDouble is wrong: refers to long (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26521/head:pull/26521
$ git checkout pull/26521

Update a local copy of the PR:
$ git checkout pull/26521
$ git pull https://git.openjdk.org/jdk.git pull/26521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26521

View PR using the GUI difftool:
$ git pr show -t 26521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26521.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2025

👋 Welcome back Korov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@Korov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363920: JVMTI Documentation for GetLocalDouble is wrong: refers to long

Reviewed-by: alanb, amenkov, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @alexmenkov, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@Korov The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 29, 2025

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, a long standing copy and paste issue it seems.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 29, 2025
@Korov
Copy link
Contributor Author

Korov commented Jul 29, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@Korov
Your change (at version b6a19df) is now ready to be sponsored by a Committer.

@Korov
Copy link
Contributor Author

Korov commented Jul 30, 2025

@alexmenkov Thank you for the review! And can you help me execute /sponsor command.

@sspitsyn
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 30, 2025

Going to push as commit 1be412d.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 30, 2025
@openjdk openjdk bot closed this Jul 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 30, 2025
@openjdk
Copy link

openjdk bot commented Jul 30, 2025

@sspitsyn @Korov Pushed as commit 1be412d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants