8363928: Specifying AOTCacheOutput with a blank path causes the JVM to crash

[calvinccheung]

Added a constraint check for the AOTCacheOutput option in order to avoid VM crash in case an empty value is specified.
Update aotFlags/AOTFlags.java to test this scenario.

Testing: ran test locally on linux-x64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8363928: Specifying AOTCacheOutput with a blank path causes the JVM to crash (Bug - P3)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26518/head:pull/26518
$ git checkout pull/26518

Update a local copy of the PR:
$ git checkout pull/26518
$ git pull https://git.openjdk.org/jdk.git pull/26518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26518

View PR using the GUI difftool:
$ git pr show -t 26518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26518.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363928: Specifying AOTCacheOutput with a blank path causes the JVM to crash

Reviewed-by: kvn, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• 4669005: 8361912: ThreadsListHandle::cv_internal_thread_to_JavaThread does not deal with a virtual thread's carrier thread
• 3e4e5dd: 8364081: Shenandoah & GenShen logging improvement
• ea0b49c: 8362979: C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF
• ... and 57 more: https://git.openjdk.org/jdk/compare/5540a7859b3ae0faf6b6c7f50e53ff611b253a9f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (78275572)

[vnkozlov]

Good.

[iklam]

LGTM

[calvinccheung]

Thanks @vnkozlov @iklam for the review.

/integrate

[openjdk]

Going to push as commit ea75431.
Since your change was applied there have been 67 commits pushed to the master branch:

• c239c0a: 8362564: hotspot/jtreg/compiler/c2/TestLWLockingCodeGen.java fails on static JDK on x86_64 with AVX instruction extensions
• 0226c02: 8364004: Expose VMError::controlledCrash via Whitebox
• 965b681: 8358586: ZGC: Combine ZAllocator and ZObjectAllocator
• ... and 64 more: https://git.openjdk.org/jdk/compare/5540a7859b3ae0faf6b6c7f50e53ff611b253a9f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit ea75431.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.