-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8364199: Enhance list of environment variables printed in hserr/hsinfo file #26509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks reasonable.
Thanks for the review ! May I have a second review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like reasonable additions.
We have a number of interesting environment variables influencing the JVM/JDK that could be added to the list of environment variables printed in the hserr/hsinfo file.
JAVA_OPTS is used by lots of tools .
WAYLAND_DISPLAY (
jdk/src/java.desktop/unix/classes/sun/awt/UNIXToolkit.java
Line 492 in 965b681
and JDK_AOT_VM_OPTIONS (
jdk/src/java.base/share/man/java.md
Line 4052 in 965b681
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26509/head:pull/26509
$ git checkout pull/26509
Update a local copy of the PR:
$ git checkout pull/26509
$ git pull https://git.openjdk.org/jdk.git pull/26509/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26509
View PR using the GUI difftool:
$ git pr show -t 26509
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26509.diff
Using Webrev
Link to Webrev Comment