8364197: G1: Sort G1 mutex locks by name and group them together

[tschatzl]

Hi all,

please review this change to put together G1 mutex definitions/declarations and sort them. That makes it easier for me to verify changes in that area.

Testing: local compilation

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8364197: G1: Sort G1 mutex locks by name and group them together (Enhancement - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26508/head:pull/26508
$ git checkout pull/26508

Update a local copy of the PR:
$ git checkout pull/26508
$ git pull https://git.openjdk.org/jdk.git pull/26508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26508

View PR using the GUI difftool:
$ git pr show -t 26508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26508.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364197: G1: Sort G1 mutex locks by name and group them together

Reviewed-by: coleenp, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• a2e86ff: 8364037: Sort share includes: adlc, libadt, metaprogramming
• e2feff8: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory
• 16da81e: 8360817: [ubsan] zDirector select_worker_threads - outside the range of representable values issue
• ... and 27 more: https://git.openjdk.org/jdk/compare/b4028c91d5615f43cbf209eeeb1014966de22a38...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (86a59dcd)

[coleenp]

That looks nice. Looks like you alphabetized them also. You could have ordered the ones in mutexLocker.cpp by rank.

[tschatzl]

That looks nice. Looks like you alphabetized them also. You could have ordered the ones in mutexLocker.cpp by rank.

Which hunk do you mean? The one assigning the nullptr or the initialization using the macros? For the latter, all other locks were separated based on the macro (MUTEX_DEFN/MUTEX_DEFL) so I kept that.

Other than that I prefer alphabetic ordering. Makes it easier to see which one is missing if you forget one....

[tschatzl]

Thanks @albertnetymk @coleenp for your reviews

/integrate

[openjdk]

Going to push as commit 5f357fa.
Since your change was applied there have been 42 commits pushed to the master branch:

• e544cd9: 8359956: Support algorithm constraints and certificate checks in SunX509 key manager
• 458f033: 8362533: Tests sun/management/jmxremote/bootstrap/* duplicate VM flags
• 3f21c8b: 8361897: gc/z/TestUncommit.java fails with Uncommitted too slow
• ... and 39 more: https://git.openjdk.org/jdk/compare/b4028c91d5615f43cbf209eeeb1014966de22a38...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 5f357fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.