-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8347114: JMXServiceURL should require an explicit protocol #25674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8347114: JMXServiceURL should require an explicit protocol #25674
Conversation
/csr |
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@kevinjwalls has indicated that a compatibility and specification (CSR) request is needed for this pull request. @kevinjwalls please create a CSR request for issue JDK-8347114 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
@kevinjwalls The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
(Test was missing from original commit.) |
This change introduces a potential compatibility with application that may be using third-party implementations of the JMXMP protocol. I do not believe JMXMP is widely used, but I could be wrong. I agree that defaulting to the "jmxmp" protocol when |
Thanks Daniel, yes there is a possibility of flushing out some niche dependencies on the odd behaviour, will go ahead with CSR and release note. |
CSR detail added. |
Remove the historic oddity that JMXServiceURL defaults to jmxmp if a null protocol is specified.
This has been the case for JMXServiceURL constructors that take individual parameters, but not for JMXServiceURL(String serviceURL), which enforces that there must be a protocol (If empty in the String, it throws: java.net.MalformedURLException: Missing or invalid protocol name: "")
A missing (null) protocol should throw a MalformedURLException for all constructors.
JMXMP was never part of the JDK, but a separate component in the historic JMX Remote reference implementation.
While we are here, remove the last remaining JMXMP references in the source:
These doc references are just examples of Connectors that support generation of client stubs. There is no need for JMXMP to be mentioned here.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25674/head:pull/25674
$ git checkout pull/25674
Update a local copy of the PR:
$ git checkout pull/25674
$ git pull https://git.openjdk.org/jdk.git pull/25674/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25674
View PR using the GUI difftool:
$ git pr show -t 25674
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25674.diff
Using Webrev
Link to Webrev Comment