8358772: Template-Framework Library: Primitive Types #25672

eme64 · 2025-06-06T13:25:48Z

I would like to add primitive type support to the template framework library.

In follow-up work, we will use these types in random expression generation - but they can also already be useful on their own now.

I encountered an issue with some methods that return Token from the TemplateFramework, such as Hook.insert and addDataName. Since Token was package private, this class could not be used in some places where automatic type inference is required. I now refactored the code, so that the Token is just an empty interface, and all the methods are moved to a separate class TokenParser.

Original experiments from here: #23418

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8358772: Template-Framework Library: Primitive Types (Sub-task - P4)

Reviewers

Manuel Hässig (@mhaessig - Author)
Christian Hagedorn (@chhagedorn - Reviewer) 🔄 Re-review required (review applies to a1c84e80)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25672/head:pull/25672
$ git checkout pull/25672

Update a local copy of the PR:
$ git checkout pull/25672
$ git pull https://git.openjdk.org/jdk.git pull/25672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25672

View PR using the GUI difftool:
$ git pr show -t 25672

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25672.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-06-06T13:26:37Z

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-06T13:26:47Z

@eme64 This change is no longer ready for integration - check the PR body for details.

openjdk · 2025-06-06T13:27:30Z

@eme64 The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-06-12T10:28:13Z

Webrevs

mhaessig

Another great addition to the Template Framework! Thank you for your continued effort, @eme64.

The broad strokes look good to me, but I have some remarks about a few details.

test/hotspot/jtreg/compiler/lib/template_framework/library/CodeGenerationDataNameType.java

mhaessig · 2025-06-12T10:44:32Z

test/hotspot/jtreg/compiler/lib/template_framework/library/PrimitiveType.java

+
+    @Override
+    public boolean isSubtypeOf(DataName.Type other) {
+        return (other instanceof PrimitiveType pt) && pt.kind == kind;


Perhaps it would be useful to implement the primitive type subtyping rules from JLS §4.10.1. I can imagine that it might help generating more diverse programs with random variables of random primitive types. That might help with fuzzing IGVN optimizations on ranges?

Very nice idea :)
I'll file a separate RFE for this. It is not a prime feature I need now, but it would be a good extension.
The user can still get exact behavior with exactOf, but also subtype behavior with subtypeOf. Nice!

Filed: JDK-8359335

test/hotspot/jtreg/compiler/lib/template_framework/library/PrimitiveType.java

test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestPrimitiveTypes.java

mhaessig · 2025-06-12T10:58:50Z

test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestPrimitiveTypes.java

+        // Create a new CompileFramework instance.
+        CompileFramework comp = new CompileFramework();
+
+        // Add a java source file.
+        comp.addJavaSourceCode("p.xyz.InnerTest", generate());
+
+        // Compile the source file.
+        comp.compile();
+
+        // p.xyz.InnerTest.main();
+        comp.invoke("p.xyz.InnerTest", "main", new Object[] {});


Personally, I would remove the comments here, since this is not a tutorial about the compile framework and the code is self-explanatory (the methods match the comments pretty well).

It is still an example, so I'll leave it. It doesn't hurt. But I may drop them in the future :)

chhagedorn

Nice additions to the library! Lot of minor comments, otherwise, looks good.

test/hotspot/jtreg/compiler/lib/template_framework/Token.java

test/hotspot/jtreg/compiler/lib/template_framework/library/CodeGenerationDataNameType.java

test/hotspot/jtreg/compiler/lib/template_framework/library/PrimitiveType.java

test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestPrimitiveTypes.java

Co-authored-by: Christian Hagedorn <[email protected]> Co-authored-by: Manuel Hässig <[email protected]>

eme64 · 2025-06-12T11:27:35Z

@chhagedorn @mhaessig Thanks for the extremely quick reviews and the good suggestions. I addressed them all :)

chhagedorn · 2025-06-12T11:28:58Z

test/hotspot/jtreg/compiler/lib/template_framework/library/CodeGenerationDataNameType.java


    /**
     * List of all {@link PrimitiveType}s.
     */
-    public static final List<PrimitiveType> PRIMITIVE_TYPES = List.of(
+    static final List<PrimitiveType> PRIMITIVE_TYPES = List.of(


static final can also be removed for constants :-) Otherwise, looks good, thanks for the update!

mhaessig

Thank you for addressing our comments so quickly. Looks good!

…ions-expressions

JDK-8358772

98ba68d

openjdk bot changed the title ~~JDK-8358772~~ 8358772: Template-Framework Library: Primitive Types, Operations and Expressions Jun 6, 2025

openjdk bot added the hotspot-compiler [email protected] label Jun 6, 2025

eme64 added 7 commits June 6, 2025 16:45

types

4def43a

add test, does not compile now

16527d0

update tests

c377093

size and boxing

fe28093

wip test

4cf7a29

improve test

e32f0a5

documentation

e34301b

eme64 changed the title ~~8358772: Template-Framework Library: Primitive Types, Operations and Expressions~~ 8358772: Template-Framework Library: Primitive Types Jun 12, 2025

eme64 added 3 commits June 12, 2025 11:24

rm unnecessary file

3971082

rm previous changes

ff76272

parser refactor

08b9f67

eme64 marked this pull request as ready for review June 12, 2025 10:24

openjdk bot added the rfr Pull request is ready for review label Jun 12, 2025

mhaessig suggested changes Jun 12, 2025

View reviewed changes

chhagedorn approved these changes Jun 12, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2025

Apply suggestions from code review

2deca27

Co-authored-by: Christian Hagedorn <[email protected]> Co-authored-by: Manuel Hässig <[email protected]>

openjdk bot removed the ready Pull request is ready to be integrated label Jun 12, 2025

eme64 and others added 2 commits June 12, 2025 11:15

Apply suggestions from code review

4c8d631

Co-authored-by: Christian Hagedorn <[email protected]> Co-authored-by: Manuel Hässig <[email protected]>

review suggestions applied

a1c84e8

chhagedorn approved these changes Jun 12, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 12, 2025

rm static final

c39d4d6

openjdk bot removed the ready Pull request is ready to be integrated label Jun 12, 2025

eme64 requested review from chhagedorn and mhaessig June 12, 2025 11:39

mhaessig approved these changes Jun 12, 2025

View reviewed changes

Merge branch 'master' into JDK-8358772-TemplateFramework-types-operat…

b07f752

…ions-expressions

8358772: Template-Framework Library: Primitive Types #25672

Are you sure you want to change the base?

8358772: Template-Framework Library: Primitive Types #25672

Conversation

eme64 commented Jun 6, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 6, 2025

Uh oh!

openjdk bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 6, 2025

Uh oh!

mlbridge bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

mhaessig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mhaessig Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

eme64 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

eme64 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mhaessig Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

eme64 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

chhagedorn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eme64 commented Jun 12, 2025

Uh oh!

chhagedorn Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eme64 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

mhaessig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eme64 commented Jun 6, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jun 6, 2025 •

edited

Loading

mlbridge bot commented Jun 12, 2025 •

edited

Loading

chhagedorn Jun 12, 2025 •

edited

Loading