First try of removing LockingMode #25660
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that contains my first try of removing the
LockingMode
option, and fix the tests that would otherwise break when removing that option.This means that in this first try I'll keep the
LockingMode
variable, but it will not be settable from the command line, all the C1 and C2 code related to legacy locking will still be in place (but as dead code) and removed later. I'm doing it this way just to get my head around what needs to be done up front to remove theLockingMode
option from a user perspective.Lightweight locking is the default locking, but the
-XX:LockingMode=0
, which is monitor locking, can now be set by using-XX:+UseHeavyMonitors
. This system made it much easier to go through and fix all the test.This draft PR covers parts of these JBS enhansments:
It's probably a good idea to break up this PR into several sub tasks that fall into the above enhancements.
This draft PR is mostly here as a basis for having a discussion on how to move forward.
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25660/head:pull/25660
$ git checkout pull/25660
Update a local copy of the PR:
$ git checkout pull/25660
$ git pull https://git.openjdk.org/jdk.git pull/25660/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25660
View PR using the GUI difftool:
$ git pr show -t 25660
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25660.diff