Calls to glUniform*() wrongly assume uniform variable is at location 0 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fix problems on 4 of the examples (see below) with the following hardware & drivers on Windows 8.1 Pro x64: - NVIDIA GeForce GTX 650 Ti with driver 353.30: - Intel HD 4400 with driver 10.18.14.4206 (OpenGL 4.3). - hdrexposure NVIDIA: no output, and the following error: GL_INVALID_OPERATION error generated. Wrong component type or count. - ktxview NVIDIA: GL_INVALID_OPERATION error generated. Wrong component type or count. Intel: no output, and the following error: Error has been generated. GL error GL_INVALID_OPERATION: GL error GL_INVALID_OPERATION: mismatched type setting uniform "s" in program 1, "" using shaders, 2, "", 3, "" - tesssubdivmodes NVIDIA: no output, and the following error: GL_INVALID_OPERATION error generated. Wrong component type or count. - wrapmodes NVIDIA: wrong output, and the following error: GL_INVALID_OPERATION error generated. Wrong component type or count.
Several of the examples let the user adjust parameters by means of the GLFW_KEY_KP_ADD (keypad +) and GLFW_KEY_KP_SUBTRACT (keypad -) keys, but these keys are not available on keyboards that lack a keypad, e.g. a number of laptop keyboards and tenkeyless keyboards. As a result, users of these keyboards can not adjust parameters in those examples. In order to allow users of said keyboards to adjust the parameters on those examples, this change modifies onKey() in the following manner: - Parameter values are decreased by pressing the GLFW_KEY_MINUS key (-) instead of GLFW_KEY_KP_SUBTRACT (keypad -) - Parameter values are increased by pressing the GLFW_KEY_EQUAL key (=) instead of GLFW_KEY_KP_ADD (keypad +). The rationale for this is that, on US and UK keyboard layout, you hold SHIFT and strike = to type +.
This reverts commit 972130b.
… keypads Several of the examples let the user adjust parameters by means of the GLFW_KEY_KP_ADD (keypad +) and GLFW_KEY_KP_SUBTRACT (keypad -) keys, but these keys are not available on keyboards that lack a keypad, e.g. a number of laptop keyboards and tenkeyless keyboards. As a result, users of these keyboards can not adjust parameters in those examples. In order to allow users of said keyboards to adjust the parameters on those examples, this change modifies onKey() in the following manner: - Parameter values are decreased, in addition to GLFW_KEY_KP_SUBTRACT (keypad -), by pressing the GLFW_KEY_MINUS key (-) - Parameter values are increased, in addition to GLFW_KEY_KP_ADD (keypad +), by pressing the GLFW_KEY_EQUAL key (=) . The rationale for this is that, on US and UK keyboard layouts, you hold SHIFT and strike = to type +.
mattgruenke
added a commit
to mattgruenke/sb7plus
that referenced
this pull request
Dec 8, 2017
Merging pull request openglsuperbible#7: openglsuperbible#7
|
Thanks for this. BTW, in my fork, I'm porting these examples to use OGLplus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix problems on 4 of the examples (see below) with the
following hardware & drivers on Windows 8.1 Pro x64:
hdrexposureGL_INVALID_OPERATION error generated. Wrong component type or count.ktxviewGL_INVALID_OPERATION error generated. Wrong component type or count.Error has been generated. GL error GL_INVALID_OPERATION: GL error GL_INVALID_OPERATION: mismatched type setting uniform "s" in program 1, "" using shaders, 2, "", 3, ""tesssubdivmodesGL_INVALID_OPERATION error generated. Wrong component type or count.wrapmodesGL_INVALID_OPERATION error generated. Wrong component type or count.Wrong:
Right: