Skip to content

[WIP] Handle NAGLCharges #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Handle NAGLCharges #1206

wants to merge 2 commits into from

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Apr 23, 2025

Description

See openforcefield/openff-toolkit#2048 for corresponding changes in OpenFF Toolkit
Provide a brief description of the PR's purpose here.

Checklist

  • Add tests
  • Lint
  • Update docstrings

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.60%. Comparing base (018e25d) to head (482128c).

Files with missing lines Patch % Lines
openff/interchange/smirnoff/_nonbonded.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
- Coverage   93.60%   93.60%   -0.01%     
==========================================
  Files          70       70              
  Lines        6039     6047       +8     
==========================================
+ Hits         5653     5660       +7     
- Misses        386      387       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant