Fix pixman warnings with android ndks before r22 #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of clang in these ndks did not pass the correct -march flag to the assembler, see: android/ndk#906 This resulted in warnings such as: ``` /tmp/pixman-radial-gradient-09b366.s: Assembler messages: /tmp/pixman-radial-gradient-09b366.s:391: Rd and Rm should be different in mla /tmp/pixman-radial-gradient-09b366.s:394: Rd and Rm should be different in mla /tmp/pixman-radial-gradient-09b366.s:398: rdhi, rdlo and rm must all be different /tmp/pixman-radial-gradient-09b366.s:403: Rd and Rm should be different in mla /tmp/pixman-radial-gradient-09b366.s:406: rdhi, rdlo and rm must all be different /tmp/pixman-radial-gradient-09b366.s:412: rdhi, rdlo and rm must all be different ```
It is necessary due to the pixman assembly files not being compatible with the llvm assembler, and we only compile assembly files if PIXMAN_ARM_NEON is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of clang in these ndks did not pass the correct -march flag to the assembler, see: android/ndk#906
This resulted in warnings such as: