Skip to content

fix: remove post-delete hook for migrate job #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove post-delete hook for migrate job #174

wants to merge 1 commit into from

Conversation

c-thiel
Copy link

@c-thiel c-thiel commented Dec 12, 2024 •
edited
Loading

Description

The post-delete hook for migrate jobs lets helm unistall hang if migration via job is enabled.
I don't believe it serves any functional purpose.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@c-thiel c-thiel requested review from a team as code owners December 12, 2024 07:37
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 12, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@rhamzeh rhamzeh added the hooks label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c-thiel @rhamzeh