Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

Bump to modern ruby #1391

Open
wants to merge 12 commits into
base: mainline
Choose a base branch
from
Open

Bump to modern ruby #1391

wants to merge 12 commits into from

Conversation

CloCkWeRX
Copy link
Contributor

No description provided.

@CloCkWeRX CloCkWeRX requested a review from RickCarlino March 13, 2023 09:54
@CloCkWeRX
Copy link
Contributor Author

@RickCarlino could you... nuke the brakeman scan check as a pre commit hook, as well, it is dead and there's a lot of dependabot security updates pending. (It's making things less secure than more secure)

@CloCkWeRX
Copy link
Contributor Author

Alternatively, just merge... #1360

@RickCarlino
Copy link
Contributor

Hey @CloCkWeRX this seems like a good idea. I am no longer involved with FarmBot/OpenFarm though so you may want to forward this to @roryaronson or @gabrielburnworth.

@CloCkWeRX
Copy link
Contributor Author

@gabrielburnworth; want to try chucking on dependabot, which will chug through and bump a bunch of dependencies?

SyntaxError:
  /home/runner/work/OpenFarm/OpenFarm/vendor/bundle/ruby/3.0.0/gems/mime-types-3.3/lib/mime/types/logger.rb:30: _1 is reserved for numbered parameter

https://github.com/mime-types/ruby-mime-types/blob/main/History.md#331--2019-12-26 fixes this

@CloCkWeRX CloCkWeRX changed the base branch from mainline to bump-mime-types April 29, 2023 05:42
Base automatically changed from bump-mime-types to mainline April 29, 2023 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RickCarlino RickCarlino Awaiting requested review from RickCarlino

1 more reviewer

@Br3nda Br3nda Br3nda approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CloCkWeRX @RickCarlino @Br3nda @gabrielburnworth