emonPiLCD1.py fix for CM firmware #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix transmitting to match expected format from EmonHubOEMInterfacer (also matches how transmission has been done before and works with emonglcd) Remove verbose mode and associated Serial.prints to get more room in flash. Verbose mode is spurious as config changes can be verified with 'l' and 'L' options, and was disabled by default. Without removing these there was no room in flash for the code. Consideration could be given in future to make the help more terse and reducing the large amount of Serial.prints uin the code to gain further space
Format temp and vrms to .2f Allow emonPiLCD1.py to work with both emonlibCM and DS firmware
|
Thanks @alandpearson I will put this on my list to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MQTT topic handling in config file (vrms pulse,temperature1 temperature2) and remove older unneeded basetopic config item (this matches how emonPiLCD2 works).
Format temp and vrms to .2f
Allow emonPiLCD1.py to work with both emonlibCM and DS firmware
Unfortunately due to my bad git branching, this PR includes fixes to emonCM firmware as discussed here:
https://community.openenergymonitor.org/t/emonsd-feb24-ttyama0-used-by-kernel-causing-interference-with-rfm-emonhub/26108/4