Skip to content

fix: ignore deleted files in submissions #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −2
Draft

fix: ignore deleted files in submissions #457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ad359
fix: ignore deleted files in submissions
samuelallan72 Jul 28, 2025
084d455
Merge branch 'master' into fix-empty-file-view
e0d Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/data/services/lms/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,15 @@ const fetchSubmission = (submissionUUID) => get(
[paramKeys.oraLocation]: locationId(),
[paramKeys.submissionUUID]: submissionUUID,
}),
).then(response => response.data);
).then(response => ({
...response.data,
response: {
...response.data.response,
// The API includes metadata for deleted files (without a download url);
// we don't want to deal with deleted files here, so filter them out like the student view does.
files: response.data.response.files.filter((file) => file.downloadUrl),
},
}));

/**
* get('/api/submission/files', { oraLocation, submissionUUID })
Expand All @@ -65,7 +73,12 @@ const fetchSubmissionFiles = (submissionUUID) => get(
[paramKeys.oraLocation]: locationId(),
[paramKeys.submissionUUID]: submissionUUID,
}),
).then(response => response.data);
).then(response => ({
...response.data,
// The API includes metadata for deleted files (without a download url);
// we don't want to deal with deleted files here, so filter them out like the student view does.
files: response.data.files.filter((file) => file.downloadUrl),
}));

/**
* fetches the current grade, gradeStatus, and rubricResponse data for the given submission
Expand Down
Loading