feature(tj): add monitoring for the gradient conflict metric of MoE in ScaleZero #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: zoo/atari/config/atari_unizero_multitask_segment_ddp_config.py
tAnGjIa520
changed the title
puyuan1996
added
research
puyuan1996
reviewed
Sep 19, 2025
| import os | ||
| from functools import partial | ||
| from typing import Tuple, Optional, List | ||
| import concurrent.futures |
Contributor
Author
There was a problem hiding this comment.
已解决，这个MoE冲突的应该是单独开一个分支的吧
Collaborator
There was a problem hiding this comment.
这个PR后面应该是放在单独的分支哈，因为与主逻辑差别较大。
puyuan1996
reviewed
Sep 26, 2025
| @@ -0,0 +1,1501 @@ | |||
| import torch | |||
| import torch.nn as nn | |||
Collaborator
There was a problem hiding this comment.
这个文件是和 https://github.com/opendilab/LightZero/pull/401/files 一致的吗？如果是改一下文件name 以及移到lzero/model/unizero_world_models/toy_multitask_moe_grad_analysis.py这个路径下吧
puyuan1996
requested changes
Sep 26, 2025
| betas=(0.9, 0.95), | ||
| ) | ||
|
|
||
| # self.a=1 |
| import os | ||
| from functools import partial | ||
| from typing import Tuple, Optional, List | ||
| import concurrent.futures |
Collaborator
There was a problem hiding this comment.
这个PR后面应该是放在单独的分支哈，因为与主逻辑差别较大。
| self.forward_handler.remove() | ||
| self.backward_handler.remove() | ||
|
|
||
| # # modified by tangjia |
| torchrun --nproc_per_node=8 ./zoo/atari/config/atari_unizero_multitask_segment_8games_ddp_config.py | ||
| """ | ||
|
|
||
| # /fs-computility/niuyazhe/tangjia/code/LightZero-dev-multitask-balance-clean/zoo/atari/config/atari_unizero_multitask_segment_ddp_config.py |
| only_use_moco_stats=False, | ||
| # use_moco=False, # ==============TODO============== | ||
| use_moco=True, # ==============TODO: moco============== | ||
| use_moco=False, # ==============TODO============== |
Collaborator
There was a problem hiding this comment.
实际scalezero moe grad分析这里是用的这个还是上面那个config？只保留使用的那个，以及写一个英文和中文 readme整体介绍一下这个PR的相关改动和moe grad分析结果的大致情况，放在config同等路径下
Contributor
Author
There was a problem hiding this comment.
use_moco=False, 这一个
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.