[WIP] LMEval Routes, Empty state setup #4274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dpanshug
force-pushed
the
lmeval-empty-state
branch
from
ec2157f to
1385fe2
Compare
pnaik1
requested changes
May 29, 2025
| variant={EmptyStateVariant.lg} | ||
| > | ||
| <EmptyStateBody> | ||
| <Stack hasGutter> |
There was a problem hiding this comment.
why do we need a Stack component here, can we not directly add the text??
| {isLmEvalAvailable && ( | ||
| <Tab | ||
| eventKey={MetricsTabKeys.LM_EVAL} | ||
| title={<TabTitleText>LM Eval</TabTitleText>} |
There was a problem hiding this comment.
Suggested change
| title={<TabTitleText>LM Eval</TabTitleText>} | |
| title={<TabTitleText>Evaluations</TabTitleText>} |
pnaik1
requested changes
May 29, 2025
| </EmptyStateBody> | ||
| <EmptyStateFooter> | ||
| <EmptyStateActions> | ||
| <Button variant="primary" onClick={() => navigate('/lmEval/evaluate')}> |
There was a problem hiding this comment.
we need to pass a state with deployed model name and namespace right?
frontend/src/pages/modelServing/screens/metrics/MetricsPage.tsx
Outdated
Show resolved
Hide resolved
dpanshug
force-pushed
the
lmeval-empty-state
branch
from
1385fe2 to
d736194
Compare
dpanshug
changed the title
* Routes * Global page * Context * Table * Empty state * Table toolbar * Core loader
dpanshug
force-pushed
the
lmeval-empty-state
branch
from
d736194 to
62e108e
Compare
dpanshug
force-pushed
the
lmeval-empty-state
branch
from
a0f3d7c to
ef764b8
Compare
|
Closing this, as created new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Navigate to deployed model details page and click on Evaluate
Test Impact
None
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main