-
Notifications
You must be signed in to change notification settings - Fork 20
chore: remove Blase dependence from SSA #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @ineol, did you measure the compile-time speedup on your machine? I am curious how much this actually is? |
I think it is great to decouple Blase and SSA. I find it useful to understand the project-wide vision. What is our vision respect to our evaluations? |
I wanted to test this because on this run compiling Mathlib to C takes a long time in the It seems there are other dependencies to mathlib |
@tobiasgrosser : My vision wrt eval is that the only dependency is the goal states, which are provided as Lean files. I propose that we zip the files from a given lean-mlir version, and use these as the goal states for our This allows us to have a stable evaluation baseline. |
@ineol if we remove |
Currently,
|
I believe this issue is not due to SSA depending on Blase. The CI has already run |
I feel there are two issues here:
|
Refactoring the evaluation blase style is a conversation that needs higher bandwidth. We should consciously decide when to have this conversation. I feel this PR may not be the right place to open this conversation. Can you maybe open an issue that we can remember to have this conversation? |
One issue is that |
This is something generally useful. We can have two files, ForLean and ForMathlib and split according to these lines. Then we can incrementally push back mathlib. |
This should speed up compilation of core Lean MLIR, but the width-independent tactics will not be exercised by the
AliveStatements.lean
workload.