Skip to content

fix: missing context attributes (breaks views) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: missing context attributes (breaks views) #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions src/main/java/io/openapitools/jackson/dataformat/hal/ser/HALBeanSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import com.fasterxml.jackson.core.JsonToken;
import com.fasterxml.jackson.core.type.WritableTypeId;
import com.fasterxml.jackson.databind.BeanDescription;
import com.fasterxml.jackson.databind.JsonMappingException;
import com.fasterxml.jackson.databind.JsonSerializer;
import com.fasterxml.jackson.databind.MapperFeature;
import com.fasterxml.jackson.databind.SerializerProvider;
import com.fasterxml.jackson.databind.jsontype.TypeSerializer;
Expand All @@ -16,13 +18,20 @@
import io.openapitools.jackson.dataformat.hal.annotation.Curies;
import io.openapitools.jackson.dataformat.hal.annotation.EmbeddedResource;
import io.openapitools.jackson.dataformat.hal.annotation.Link;
import java.io.IOException;
import java.util.*;
import java.util.stream.Collectors;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.TreeMap;
import java.util.TreeSet;

/**
* Serializer to handle {@link io.openapitools.jackson.dataformat.hal.annotation.Resource} beans ensuring they are serialized according to the HAL
* specification. This implies placing links inside the <code>_links</code> property and embedded objects inside the <code>_embedded</code>
Expand Down Expand Up @@ -200,7 +209,7 @@ public void serialize(Object bean, JsonGenerator jgen, SerializerProvider provid
jgen.writeStartObject();
for (String rel : links.keySet()) {
jgen.writeFieldName(rel);
links.get(rel).serialize(jgen);
links.get(rel).serialize(jgen, provider);
}
jgen.writeEndObject();
}
Expand Down Expand Up @@ -285,22 +294,30 @@ public LinkProperty(Collection<HALLink> links) {
this.links = links == null ? new HashSet<HALLink>() : links;
}

public void serialize(JsonGenerator jgen) throws IOException {
public void serialize(JsonGenerator jgen, SerializerProvider provider) throws IOException {
if (link != null) {
writeLinkObject(jgen, link);
writeLinkObject(jgen, provider, link);
} else if (links != null) {
jgen.writeStartArray();
for (HALLink curLink : links) {
writeLinkObject(jgen, curLink);
writeLinkObject(jgen, provider, curLink);
}
jgen.writeEndArray();
}
}

private void writeLinkObject(JsonGenerator jgen, HALLink link) throws IOException {
jgen.writeObject(link);
private void writeLinkObject(JsonGenerator jgen, SerializerProvider provider, HALLink link) throws IOException {
_findSerializer(link, provider).serialize(link, jgen, provider);
}

protected JsonSerializer<Object> _findSerializer(Object value, SerializerProvider serializers)
throws JsonMappingException
{
// NOTE: will NOT call contextualization
return serializers.findValueSerializer(value.getClass());
}
}



}