-
Notifications
You must be signed in to change notification settings - Fork 341
[Dependencies] Override glob version to fix dev dependency vulnerability #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a security vulnerability by updating the glob package from version 7.2.3 to 11.1.0 through package overrides. The update involves major version bumps to multiple dev dependencies including c8 (9.1.0 → 10.1.3), vitest (1.4.0 → 4.0.10), and vite (5.4.21 → 7.2.2).
Key Changes
- Added npm overrides to force
globto version^11.1.0throughout the dependency tree - Updated multiple dev dependencies to their latest major versions to support the glob override
- Removed
copyfilesdependency from codegen package
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Added overrides section to force glob 11.1.0 across all dependencies |
| codegen/package.json | Updated c8, vitest, rimraf, and removed copyfiles; reordered dependencies alphabetically |
| package-lock.json | Reflects all dependency updates with glob now at 11.1.0 and major version bumps for vitest (1→4), vite (5→7), c8 (9→10), and rimraf (5→6) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@joseharriaga I've opened a new pull request, #842, to work on those changes. Once the pull request is ready, I'll request review from you. |
jsquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd appreciate a look from @JoshLove-msft, as the authoritative voice.
|
Seems okay to me but just curious if |
@JoshLove-msft : The problem was that |
The vulnerability in the
test-excludepackage (which was pulling in the old glob version) has been resolved by updatingc8to the latest version and applying package overrides to ensure glob 11.1.0 is used throughout the dependency tree.Updated
c8from^9.1.0to^10.1.3(latest version)Updated other dependencies too.
overridessection to forceglobto version^11.1.0Verification:
✅
npm auditnow reports 0 vulnerabilities✅
globhas been updated from 7.2.3 (vulnerable) to 11.1.0 (secure)✅ All transitive dependencies have been properly updated