Skip to content

fix: add missing mcp_approval_response event name (fixes #1020) #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

fix: add missing mcp_approval_response event name (fixes #1020) #1931

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c1d920
fix: add missing mcp_approval_response event name (fixes #1020)
Oct 18, 2025
e2d51ea
Merge branch 'main' into fix/mcp-approval-response-event-1020
gn00295120 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/agents/_run_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,8 @@ def stream_step_items_to_queue(
event = RunItemStreamEvent(item=item, name="reasoning_item_created")
elif isinstance(item, MCPApprovalRequestItem):
event = RunItemStreamEvent(item=item, name="mcp_approval_requested")
elif isinstance(item, MCPApprovalResponseItem):
event = RunItemStreamEvent(item=item, name="mcp_approval_response")
elif isinstance(item, MCPListToolsItem):
event = RunItemStreamEvent(item=item, name="mcp_list_tools")

Expand Down
1 change: 1 addition & 0 deletions src/agents/stream_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class RunItemStreamEvent:
"tool_output",
"reasoning_item_created",
"mcp_approval_requested",
"mcp_approval_response",
"mcp_list_tools",
]
"""The name of the event."""
Expand Down