Handle processor exceptions and fix tracing log formatting #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Wrap each call in `SynchronousMultiTracingProcessor` (`on_trace_start`, `on_trace_end`, `on_span_start`, `on_span_end`, `shutdown`, `force_flush`) in a `try/except` so one failing processor won’t prevent the others from running. * Add a missing space in the `logger.error` message when no active trace is found, ensuring it reads “…first Returning NoOpSpan.” cleanly.
seratch
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
in general, on_xxx callbacks are responsible to handle runtime exceptions, but having these should be good to go; @rm-openai can you review this just in case?
rm-openai
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap each call in
SynchronousMultiTracingProcessor(on_trace_start,on_trace_end,on_span_start,on_span_end,shutdown,force_flush) in atry/exceptso one failing processor won’t prevent the others from running.Add a missing space in the
logger.errormessage when no active trace is found, ensuring it reads “…first Returning NoOpSpan.” cleanly.