-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add /compact #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add /compact #1724
Conversation
SummaryMakes several ReviewNice functional upgrade and tidy Rust implementation! A few quick suggestions:
Other than those minor points, looks solid and the added tests are great. |
let appended = match cfg.base_instructions.take() { | ||
Some(existing) => format!("{existing}\n\n{prefix}\n{summary}\n"), | ||
None => format!("{prefix}\n{summary}\n"), | ||
}; | ||
cfg.base_instructions = Some(appended); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this result in repeatedly appending to the base instructions if using /compact more than once?
Adding @pakrym-oai and @ibahmed-oai as reviewers because there was already a lot of discussion on a related PR: #1529 |
I talked about this with @easong-openai . This approach is building on top of #1495 and #1497 . We thought that this approach isn't the best because we are calling the model in As @bolinfest mentioned, we had good iterations on #1527 and #1529 . I think this is a better appraoch because the logic goes to the |
Adds an initial /compact command that summarizes the existing conversation and also introduces scrolling to the slash command modal. There's probably more work to do on the prompt.