port login server to rust #1717
Conversation
| hyper = { version = "1", features = ["http1", "server"] } | ||
| hyper-util = { version = "0.1", features = ["tokio"] } | ||
| open = "5" | ||
| url = "2" | ||
| base64 = "0.22" | ||
| sha2 = "0.10" | ||
| rand = "0.8" | ||
| http-body-util = "0.1" |
There was a problem hiding this comment.
Having to pay the tax of embedding an entire HTTP server is the reason I had been avoiding this to date...
There was a problem hiding this comment.
tax
what kind of tax?
IMO depending on python is a much larger tax than shipping a few extra KB.
- 238K libcodex_login.rlib
+ 562K libcodex_login.rlibThere was a problem hiding this comment.
Alpha sort this list, please.
| hyper = { version = "1", features = ["http1", "server"] } | ||
| hyper-util = { version = "0.1", features = ["tokio"] } | ||
| open = "5" | ||
| url = "2" | ||
| base64 = "0.22" | ||
| sha2 = "0.10" | ||
| rand = "0.8" | ||
| http-body-util = "0.1" |
There was a problem hiding this comment.
Alpha sort this list, please.
| } | ||
| } | ||
|
|
||
| fn serde_urlencode(params: &[(String, String)]) -> String { |
There was a problem hiding this comment.
Why is this named serde_urlencode()?
| Ok(()) | ||
| } | ||
|
|
||
| #[allow(clippy::unwrap_used)] |
There was a problem hiding this comment.
Why is this using unwrap() instead of forwarding the Err variant?
| } | ||
|
|
||
| // Public entry point used by lib.rs | ||
| pub async fn run_login_server(codex_home: &Path) -> std::io::Result<()> { |
There was a problem hiding this comment.
Please list the pub entrypoint before the helper functions.
| use crate::CLIENT_ID; | ||
| use crate::TokenData; | ||
|
|
||
| const REQUIRED_PORT: u16 = 1455; |
There was a problem hiding this comment.
I would preserve this client from the Python: # Required port for OAuth client.
|
|
||
| const REQUIRED_PORT: u16 = 1455; | ||
| const URL_BASE: &str = "http://localhost:1455"; | ||
| const DEFAULT_ISSUER: &str = "https://auth.openai.com"; |
There was a problem hiding this comment.
Where is DEFAULT_CLIENT_ID?
| None | ||
| } | ||
|
|
||
| const LOGIN_SUCCESS_HTML: &str = include_str!("static/success.html"); |
replace the python login server with rust.
codex ported this, and I haven't thoroughly checked the logic, but it does work.