-
Notifications
You must be signed in to change notification settings - Fork 3.7k
adding /model to set the current model in TUI #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
SummaryAdds an interactive Notes
ReviewNice ergonomic improvement—runtime model switching feels smooth! A few nits before merge:
Overall, functionally solid—just tidy up the small issues and this is good to go! |
moved
done and changed refactored file search so it uses it too |
Appears to be broken in the new UI? can type /model and hit enter and nothing appears after that. |
This does work, but there's a common pattern between several of our slash commands (and the @ menu) (including the base / itself), which is pressing /, then getting a dropdown that you navigate between, and then up/downing between them. In most cases we're going to want very similar scrolling/resizing primitives. I think we should make this some kind of component (I am terminally react brained) so that we don't have a multiple implementations running at the same time. Are you opposed to me merging this PR with the scrollable one and then we can reuse the same scrolling component? |
@easong-openai sounds good – are you bringing the scrolling component directly in this branch? |
/model
slash command/model "xxx"
sets the model, can be custom or selected from the dropdown shown below when pressing enter/model
returns a navigable dropdown of models/model
also reads from config.toml to list models defined locally as per the last model on screenshot above/model
dropdown is searchable