Skip to content

Conversation

@okurz okurz marked this pull request as draft October 22, 2025 12:55
@okurz okurz changed the title Enable all ruff checks that potentially make sense PART 3: Enable all ruff checks that potentially make sense - After #250 Oct 22, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 01f6d0d to 9dba3f7 Compare October 22, 2025 15:52
@openSUSE openSUSE deleted a comment from mergify bot Oct 22, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 9dba3f7 to 2926494 Compare October 23, 2025 18:50
@okurz okurz changed the title PART 3: Enable all ruff checks that potentially make sense - After #250 PART 3: Enable all ruff checks that potentially make sense - After #250+#255 Oct 23, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 2926494 to 225809f Compare October 24, 2025 19:10
@okurz okurz changed the title PART 3: Enable all ruff checks that potentially make sense - After #250+#255 PART 3: Enable all ruff checks that potentially make sense - After #250+#255+#258 Oct 24, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch 2 times, most recently from bbe914a to 1fbdffe Compare October 26, 2025 21:41
@okurz okurz changed the title PART 3: Enable all ruff checks that potentially make sense - After #250+#255+#258 PART 4: Enable all ruff checks that potentially make sense - After #250+#255+#258+#259 Oct 26, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 1fbdffe to 3761d41 Compare October 26, 2025 21:48
@okurz okurz changed the title PART 4: Enable all ruff checks that potentially make sense - After #250+#255+#258+#259 PART 4: Enable all ruff checks that potentially make sense - After #250+#255+#258+#259+#260 Oct 27, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 3761d41 to 996cd08 Compare October 27, 2025 08:14
@okurz okurz changed the title PART 4: Enable all ruff checks that potentially make sense - After #250+#255+#258+#259+#260 PART 5: Enable all ruff checks that potentially make sense - After #250+#255+#258+#259+#260 Oct 27, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 996cd08 to 0eeb237 Compare October 28, 2025 11:41
@openSUSE openSUSE deleted a comment from mergify bot Oct 28, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 0eeb237 to a0d0de4 Compare October 29, 2025 10:40
@okurz
Copy link
Member Author

okurz commented Oct 29, 2025

Peer-reviewed and generally agreed with the rule-set

@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch 2 times, most recently from e7497b9 to f8b1d4a Compare November 7, 2025 18:14
@openSUSE openSUSE deleted a comment from mergify bot Nov 7, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from f8b1d4a to 920d30a Compare November 13, 2025 22:03
@openSUSE openSUSE deleted a comment from mergify bot Nov 13, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 920d30a to 5f3c0ef Compare November 15, 2025 21:43
@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 93.08511% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.42%. Comparing base (735ff61) to head (59ae2a7).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
openqabot/osclib/comments.py 0.00% 7 Missing ⚠️
openqabot/commenter.py 0.00% 5 Missing ⚠️
openqabot/loader/smelt.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   76.33%   76.42%   +0.08%     
==========================================
  Files          32       32              
  Lines        2692     2706      +14     
==========================================
+ Hits         2055     2068      +13     
- Misses        637      638       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch 2 times, most recently from c1fe97b to 19f3267 Compare November 15, 2025 22:03
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch 4 times, most recently from c672a70 to 8199da8 Compare November 18, 2025 14:57
@okurz okurz changed the title PART 3: Enable all ruff checks that potentially make sense - After #286+#283 PART 2: Enable all ruff checks that potentially make sense - After #286+#283 Nov 20, 2025
@okurz okurz changed the title PART 2: Enable all ruff checks that potentially make sense - After #286+#283 PART 2: Enable all ruff checks that potentially make sense - After #283 Nov 20, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from 8199da8 to fe611f9 Compare November 20, 2025 09:11
@openSUSE openSUSE deleted a comment from mergify bot Nov 20, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from fe611f9 to a74626e Compare November 20, 2025 10:29
@okurz okurz changed the title PART 2: Enable all ruff checks that potentially make sense - After #283 PART 2: Enable all ruff checks that potentially make sense - After #303 Nov 20, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch 3 times, most recently from cd92f65 to e8d96d9 Compare November 20, 2025 13:03
@okurz okurz removed the not-ready label Nov 20, 2025
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from e8d96d9 to eb953dd Compare November 20, 2025 15:08
@okurz okurz force-pushed the feature/ruff_more_style_checks_from_list_of_all branch from eb953dd to 59ae2a7 Compare November 20, 2025 15:11
@okurz okurz removed the not-ready label Nov 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

This pull request, with head sha 59ae2a7191d63d79a3c28b38b2411fcb8285c2b2, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 59ae2a7191d63d79a3c28b38b2411fcb8285c2b2 is part of the master branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch feature/ruff_more_style_checks_from_list_of_all, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 59ae2a7 into openSUSE:master Nov 20, 2025
6 checks passed
@okurz okurz deleted the feature/ruff_more_style_checks_from_list_of_all branch November 20, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants