-
Notifications
You must be signed in to change notification settings - Fork 2
1680: Improve error when exporting through an account_link #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
1680: Improve error when exporting through an account_link #1846
Conversation
7964ce7
to
1818ac3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1846 +/- ##
==========================================
+ Coverage 94.85% 94.87% +0.01%
==========================================
Files 133 133
Lines 3385 3392 +7
==========================================
+ Hits 3211 3218 +7
Misses 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
1818ac3
to
c6ee504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the further adjustments. I can confirm that only escaped strings are returned. 👏
💁 Please keep in mind: I have not done a regular code review.
c6ee504
to
4b5dc99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions for the translations 🙂
4b5dc99
to
52780c8
Compare
Co-authored-by: Sebastian Serth <[email protected]>
Added a more descriptive error message for the presumably most common error.