Skip to content

Add Dapr on in the Cart Service #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 64 commits into
base: main
Choose a base branch
from

Conversation

henrikrexed
Copy link

Changes

Please provide a brief description of the changes here.

Service impacted: cart service
I have removed the usage of the redis client to replace it with the usage of Dapr client.
I have also added the Dapr folder container :

  • Dapr configuration to enable traces
  • the component directory that will hold the configuration to the backend. for cart service the default backend will be valley
  • added changes in the docker-compose to have Dapr configure

I also added the new service : sqlite that will be used in the future for he product catalog ( replace file usage with a database).

I have prepare the changes on the helm chart but I will create a pr once this has been merged.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • [X ] CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@henrikrexed henrikrexed requested a review from a team as a code owner April 8, 2025 10:43
Copy link

linux-foundation-easycla bot commented Apr 8, 2025

@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Apr 8, 2025
@julianocosta89
Copy link
Member

julianocosta89 commented May 12, 2025

@mviitane and @puckpuck have you discussed about this one while I was away?
I like the idea and that was a lot of effort that @henrikrexed put in!
I wouldn't like to waste it

@mviitane
Copy link
Member

@mviitane and @puckpuck have you discussed about this one while I was away? I like the idea and that was a lot of effort that @henrikrexed put in! I wouldn't like to waste it

We haven't discussed this lately. Some time ago I noticed many of the checks failing, but Henrik tried to fix those. I would also like to get this forward, but the conflicts and checks should be solved.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

# Conflicts:
#	CHANGELOG.md
#	src/cart/src/Program.cs
#	src/cart/src/cart.csproj
#	src/product-catalog/Dockerfile
#	src/product-catalog/go.mod
@henrikrexed
Copy link
Author

hi,

I have applied new changes to pass the Checks ( except license but does not seem to be required)

Copy link

github-actions bot commented Jun 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants