-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add Dapr on in the Cart Service #2143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
change the local changes
using the dapr client to query the content.
@mviitane and @puckpuck have you discussed about this one while I was away? |
We haven't discussed this lately. Some time ago I noticed many of the checks failing, but Henrik tried to fix those. I would also like to get this forward, but the conflicts and checks should be solved. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
# Conflicts: # CHANGELOG.md # src/cart/src/Program.cs # src/cart/src/cart.csproj # src/product-catalog/Dockerfile # src/product-catalog/go.mod
hi, I have applied new changes to pass the Checks ( except license but does not seem to be required) |
# Conflicts: # src/cart/src/cart.csproj
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Changes
Please provide a brief description of the changes here.
Service impacted: cart service
I have removed the usage of the redis client to replace it with the usage of Dapr client.
I have also added the Dapr folder container :
I also added the new service : sqlite that will be used in the future for he product catalog ( replace file usage with a database).
I have prepare the changes on the helm chart but I will create a pr once this has been merged.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.